Open
Conversation
Contributor
|
これは :servo-id はアクチュエータークラスだけに付ける意図はあるが、コードが複雑になるからしていないのかな? 以下の :actuator-name のところに servo-id を加えてもいいけれども。urdfに書き出すのが難しいかもしれない。 |
Contributor
Author
|
お返事遅れました.
アクチュエータ以外のリンクに関しても,将来的に何か特殊 attrib をつけたくなったときに再利用できるかなと思っていましたが, ここにまとめる場合,
ことが考えられそうですが,どちらのほうが都合いいですかね? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
以下の機能を追加しました.
(:servo-id ...)としてサーボ ID の情報を持たせた.:servo-idが付くので,将来的にはより一般性の高い名前にして一般の attrib を持たせられるようにしたほうがいい?<joint>...</joint>内に,<servo id="..." />としてサーボ ID 情報を持たせた.TODO: GUI 上からサーボ ID を振れるようにする.