Actor crash detection (part 1/3): crash an actor if ateom pod has terminated#493
Open
Zoe Zhao (zoez7) wants to merge 4 commits into
Open
Actor crash detection (part 1/3): crash an actor if ateom pod has terminated#493Zoe Zhao (zoez7) wants to merge 4 commits into
Zoe Zhao (zoez7) wants to merge 4 commits into
Conversation
Zoe Zhao (zoez7)
force-pushed
the
crash-detect
branch
2 times, most recently
from
July 22, 2026 17:01
49e0181 to
6c9c30d
Compare
Zoe Zhao (zoez7)
force-pushed
the
crash-detect
branch
from
July 22, 2026 17:02
6c9c30d to
665a224
Compare
Zoe Zhao (zoez7)
marked this pull request as draft
July 22, 2026 17:05
Zoe Zhao (zoez7)
force-pushed
the
crash-detect
branch
from
July 22, 2026 18:20
fc9d1a1 to
9d32e47
Compare
Zoe Zhao (zoez7)
marked this pull request as ready for review
July 22, 2026 18:21
Eitan Yarmush (EItanya)
left a comment
Eitan Yarmush (EItanya)
left a comment
Collaborator
There was a problem hiding this comment.
Just some clarifying questions
| } | ||
| } | ||
| // Deleting the pod, because the actor network may not have been cleaned up from the Ateom Pod's net NS. | ||
| if err := s.kubeClient.CoreV1().Pods(pod.Namespace).Delete(ctx, pod.Name, metav1.DeleteOptions{ |
Collaborator
There was a problem hiding this comment.
Maybe I'm totally misunderstanding something, if the ateom crashed wouldn't that automatically rollout the pod because we're using a Deployment under the hood?
Collaborator
Author
There was a problem hiding this comment.
This is because the ateom container's crash will be detected by kubelet, which will restart the ateom container in the same pod.
You are right that once we delete this pod, the Deployment will automatically create a new one.
Collaborator
There was a problem hiding this comment.
🤦
And the worry is that there will be dangling networking and/or other resources if we don't manually kill the pod?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #292
This is the first CL for detecting a running Actor has crashed, and mark it as so in Redis. The overall plan is to
This CL implements the logic in Workerpool syncer to detect ateom container terminated. There are 2 more PRs coming which will implement the logic to monitor actor process in ateom-gvisor and ateom-microvm.