Skip to content

Need an install settings from a config file to persist configurations #1887

Description

@HavenXia

Today ate-setup takes its install settings from three places:

  1. .ate-dev-env.sh at the root of the checkout it runs from
  2. the shell environment
  3. ate-setup flags in cmd/ate-setup/commands.md.

That makes any redeploy risky, and an upgrade redeploys every component. For example: deploy atenet without --atenet-dataplane, --experimental-use-sdsmint, --experimental-egress-credential-injection .etc goes back to the default dataplane and drops the egress features.

Proposal

Scope: OSS only.

Add a config file for ate-setup, passed with --config.

It holds all the settings that define the install shape, such as image repos, image tags (for release), the atenet dataplane and egress features, telemetry and the database. An user (substrate operator) keeps one file and passes it to every run, including upgrades.

.ate-dev-env.sh may stay for developers.

Open questions

  • One file with a section per component, or one file per component? ate-api-server is getting its own proto-based config file by Taahir Ahmed (@ahmedtd) , maybe the installer config could embed that type instead of repeating its fields.
  • Precedence between the config file, the environment and flags, which overwrite which?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions