Skip to content

[CLIENT-4697] Refactor map operations conversion code in cdt_map_operate.c. This only affects a few map operations#1053

Merged
juliannguyen4 merged 72 commits into
devfrom
CLIENT-4697-refactor-only-cdt_map_operate
Jul 8, 2026
Merged

[CLIENT-4697] Refactor map operations conversion code in cdt_map_operate.c. This only affects a few map operations#1053
juliannguyen4 merged 72 commits into
devfrom
CLIENT-4697-refactor-only-cdt_map_operate

Conversation

@juliannguyen4

@juliannguyen4 juliannguyen4 commented May 8, 2026

Copy link
Copy Markdown
Collaborator

This further reduces technical debt

Affected ops:

  • map_remove_by_value_rel_rank_range
  • map_get_by_value_rel_rank_range
  • map_remove_by_key_rel_index_range
  • map_get_by_key_rel_index_range

TODO (out of scope)

  • Documentation for these ops needs improvement.

@codecov-commenter

codecov-commenter commented May 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.33962% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.36%. Comparing base (5788328) to head (639146f).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/client/cdt_operation_utils.c 84.61% 2 Missing ⚠️
src/main/client/operate_helper.c 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1053      +/-   ##
==========================================
+ Coverage   85.25%   85.36%   +0.11%     
==========================================
  Files         102      101       -1     
  Lines       14694    14602      -92     
==========================================
- Hits        12527    12465      -62     
+ Misses       2167     2137      -30     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

juliannguyen4 and others added 15 commits May 8, 2026 15:47
Bumps [aerospike-client-c](https://github.com/aerospike/aerospike-client-c) from `785fa24` to `bce75a6`.
- [Release notes](https://github.com/aerospike/aerospike-client-c/releases)
- [Commits](aerospike/aerospike-client-c@785fa24...bce75a6)

---
updated-dependencies:
- dependency-name: aerospike-client-c
  dependency-version: bce75a68adcce897c7e58168113bf928097fb0bd
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@juliannguyen4 juliannguyen4 changed the base branch from dev to dependabot/submodules/dev/aerospike-client-c-bce75a6 July 7, 2026 21:30
…IT_FAILED as module constants for application users to check their txn state.
Base automatically changed from dependabot/submodules/dev/aerospike-client-c-bce75a6 to dev July 8, 2026 14:22
@juliannguyen4

Copy link
Copy Markdown
Collaborator Author

Build artifacts all passes
Massif graph looks ok
Valgrind shows no memory errors or leaks

@juliannguyen4 juliannguyen4 marked this pull request as ready for review July 8, 2026 15:21
@juliannguyen4 juliannguyen4 merged commit 1cb7747 into dev Jul 8, 2026
108 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-4697-refactor-only-cdt_map_operate branch July 8, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants