fix(csharp): enforce SetOption validation for BatchSize, PollTime, QueryTimeout in SEA (PECO-3011)#448
Open
eric-wang-1990 wants to merge 1 commit into
Conversation
…eryTimeout in SEA (PECO-3011) StatementExecutionStatement.SetOption silently accepted all values for BatchSize, PollTimeMilliseconds, QueryTimeoutSeconds, and BatchSizeStopCondition. Add the same ArgumentOutOfRangeException validation that the Thrift path applies so clients get consistent errors across both protocols. Also validate these options from connection properties at statement creation time. Remove the Skip.If guards for CanSetOptionBatchSize, CanSetOptionPollTime, and CanSetOptionQueryTimeout in StatementTests. Closes #NNN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StatementExecutionStatement.SetOptionwas silently accepting all values forBatchSize,PollTimeMilliseconds,QueryTimeoutSeconds, andBatchSizeStopConditionwith no validationArgumentOutOfRangeExceptionvalidation that the Thrift path (HiveServer2Statement) applies, so clients get consistent errors across both protocolsValidateOptionsbehaviorSkip.Ifguards forCanSetOptionBatchSize,CanSetOptionPollTime, andCanSetOptionQueryTimeoutinStatementTestsTest plan
CanSetOption{BatchSize,PollTime,QueryTimeout}test cases pass on SEA path (protocol: rest)Closes #NNN