Default tag_name and release_name to be github.ref#53
Default tag_name and release_name to be github.ref#53jasonkarns wants to merge 2 commits intoactions:masterfrom
github.ref#53Conversation
github.ref
|
closes #26 |
|
@jasonkarns Additionally please remove the |
|
@shivapoudel I'm not against that, but doing so would be a more invasive change that would decrease the chance this PR gets merged. Perhaps open as a separate PR? |
|
@jasonkarns Thanks for the suggestion, I have raised a PR #66 for this separately. |
|
bump |
|
In my repository, Otherwise, I'd propose to choose another default tag name, also in the example in the README.md, maybe based on the commit SHA ( Just my 2 cents :) |
|
I followed the readme, ended up with 'Release refs/heads/master' :( |
|
|

For most workflows (indeed, even in the example for this action), this action will be scoped to only run for version tags. So for most workflows, it is highliy likely that the tag-name for the release ought to be the same as
${{ github.ref }}. In the spirit of convention over configuration, that would make a desirable default.Similarly for the release_name. This actually results in the same behavior as when creating a release manually through the UI (the default release name is the same as the tag name, unless given explicitly).
(Pattern of setting defaults via expression directly in the manifest taken from actions/checkout.)