feat: add Windows x64 support - #31
Conversation
- Add win32-x64 to platform package map in bin-resolve.ts and postinstall.cjs - Add postagent-win32-x64 optional dependency in package.json - Create postagent-win32-x64 platform package with native binary target - Handle .exe extension for Windows binaries - Add Windows x64 build target (x86_64-pc-windows-msvc) to CI matrix - Update README with platform support info and build-from-source guide
|
@codex review |
💡 Codex Reviewpostagent/packages/postagent/package.json Line 37 in 63914da This adds a new workspace optionalDependency, but postagent/packages/postagent-win32-x64/package.json Lines 2 to 3 in 63914da This introduces a sixth npm package, but Line 35 in 63914da Running this from the repository root does not install the CLI: the root ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Hi @Paul-Yuchao-Dong , thanks for contribution! But there are some issues in this PR, please fix them. |
This PR adds native Windows x64 (x86_64-pc-windows-msvc) support to postagent.
Changes
postagent-win32-x64— publishes a native Windows binary via npm, following the same optional-dependency pattern as the existing darwin/linux packages.bin-resolve.tsandpostinstall.cjsnow mapwin32-x64topostagent-win32-x64, using.exeextension on Windows.chmoderrors on Windows are caught (it's a no-op there).x86_64-pc-windows-msvctarget running onwindows-latestto the publish workflow, and included the win32-x64 package in the publish loop.Testing
Tested on Windows 11 x64 with Node.js —
postagentCLI resolves the native binary correctly,postinstallruns without errors, and the.exeextension is handled properly.Fixes # (no existing issue — new platform target)