SOA-503 — Corriger et récapituler les rapports d'erreurs#65
SOA-503 — Corriger et récapituler les rapports d'erreurs#65jvk88511334 wants to merge 6 commits into
Conversation
…ers/villiseck.LEVANT/Documents/Plateformes/convergence/logskbart-api/src/test/java/fr/abes/logskbart/kafka/ErrorClassifierTest.java). Ils couvrent six cas : Deux messages contenant publication title : → AUTRE_ERREUR. Quatre erreurs de validation sans ce marqueur → ERREUR_400.
Add JUnit 5 tests for ErrorClassifier (src/test/java/fr/abes/logskbart/kafka/ErrorClassifierTest.java). Tests assert that messages containing duplicate KBART data are classified as AUTRE_ERREUR (including when the duplicate marker appears anywhere in the message) and that various validation messages are classified as ERREUR_400 using a parameterized test.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2003f0cd81
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Files.deleteIfExists(report400); | ||
| Files.deleteIfExists(reportOther); |
There was a problem hiding this comment.
When the same KBART filename is processed again before the daily recap runs (or before someone clicks an immediate _other.bad email), these deletes remove the existing reports even if the new run has no errors in that category. Because the recap finder uses the durable _400.bad files as its source of truth, a pending 400 report can disappear without ever being included, and previously sent _other.bad links can become dead after a clean retry.
Useful? React with 👍 / 👎.
1 participant
Pourquoi
Les erreurs de validation 400 et les autres erreurs étaient regroupées dans un même rapport et les fichiers
.badn'étaient pas conservés dans un emplacement durable. Les erreurs 400 généraient également trop de notifications immédiates.Modifications
bad/;<fichier>_400.badet<fichier>_other.badselon la présence depublication title :;_other.badpour les erreurs hors 400 ;_400.bad;Impact
Les rapports restent accessibles dans le volume de rapports configuré. Les fonctionnels reçoivent les erreurs hors 400 immédiatement et les erreurs 400 dans un seul email quotidien.
Validation
mvn clean test