-
Notifications
You must be signed in to change notification settings - Fork 109
feat: Rework Event Queues to use central event bus #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ed6045f
feat: Rework Event Queues to use central event bus
kabir c0837cd
Cleanup and ensure that we now only listen to ChildQueues.
kabir d6a6a07
Get rid of the background processing
kabir 1846e9c
Gemini feedback and fixing tests
kabir 4bcaa55
Move sepaphore into MainQueue
kabir 7825bdf
TCK fixes
kabir 495b9b3
TCK fixes 2
kabir 5e8164d
Debug logging
kabir e58dd7a
Fix failing test
kabir 368cbec
TCK fixes
kabir a2b0a79
Debug: Add extensive logging to REST SSE streaming
kabir 11b855e
TCK working
kabir a3f4c06
fix: Allow gracefully closed ChildQueues to accept events from MainEv…
kabir 5257d2b
fix: Use agentCompleted flag in EventConsumer for graceful streaming …
kabir 5e5faa2
All a2a-java and TCK tests pass!
kabir 9c2d340
Fix needed to get grpc to work after rebase
kabir 0018038
Move processor callback registration to DefaultRequestHandler
kabir c499994
Rework SSE support
kabir a92815a
Reduce logging
kabir 0974081
Move thread stats into own logging category
kabir a570ec9
Clean up some comments
kabir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
234 changes: 158 additions & 76 deletions
234
.../src/test/java/io/a2a/extras/queuemanager/replicated/core/ReplicatedQueueManagerTest.java
Large diffs are not rendered by default.
Oops, something went wrong.
11 changes: 11 additions & 0 deletions
11
extras/queue-manager-replicated/core/src/test/java/io/a2a/server/events/EventQueueUtil.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package io.a2a.server.events; | ||
|
|
||
| public class EventQueueUtil { | ||
| public static void start(MainEventBusProcessor processor) { | ||
| processor.start(); | ||
| } | ||
|
|
||
| public static void stop(MainEventBusProcessor processor) { | ||
| processor.stop(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| #!/usr/bin/env python3 | ||
| import re | ||
| import sys | ||
| import glob | ||
|
|
||
| test_files = glob.glob('**/src/test/java/**/*Test.java', recursive=True) | ||
|
|
||
| for path in test_files: | ||
| try: | ||
| with open(path, 'r') as f: | ||
| content = f.read() | ||
|
|
||
| # Pattern to match create() calls with 5 arguments ending with executor or internalExecutor | ||
| pattern = r'DefaultRequestHandler\.create\(\s*([^,]+),\s*([^,]+),\s*([^,]+),\s*([^,]+),\s*((?:executor|internalExecutor))\s*\)' | ||
|
|
||
| def replacer(match): | ||
| args = [match.group(i).strip() for i in range(1, 6)] | ||
| executor = args[4] | ||
| return f'DefaultRequestHandler.create({args[0]}, {args[1]}, {args[2]}, {args[3]}, {executor}, {executor})' | ||
|
|
||
| new_content = re.sub(pattern, replacer, content, flags=re.MULTILINE | re.DOTALL) | ||
|
|
||
| if new_content != content: | ||
| with open(path, 'w') as f: | ||
| f.write(new_content) | ||
| print(f'Fixed: {path}') | ||
| except Exception as e: | ||
| print(f'Error processing {path}: {e}') |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,6 @@ | ||
| quarkus.arc.selected-alternatives=io.a2a.server.apps.common.TestHttpClient | ||
|
|
||
| # Debug logging for event processing and request handling | ||
| quarkus.log.category."io.a2a.server.events".level=DEBUG | ||
| quarkus.log.category."io.a2a.server.requesthandlers".level=DEBUG | ||
| quarkus.log.category."io.a2a.server.tasks".level=DEBUG |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.