UI improvements, bug fix -- seed run on duckdb#36
Open
Deepak-Gnanasekar wants to merge 7 commits intomainfrom
Open
UI improvements, bug fix -- seed run on duckdb#36Deepak-Gnanasekar wants to merge 7 commits intomainfrom
Deepak-Gnanasekar wants to merge 7 commits intomainfrom
Conversation
|
| Filename | Overview |
|---|---|
| backend/visitran/adapters/duckdb/seed.py | Adds null-guard on db_connection and wraps insert_csv_records in a try/except that re-raises SeedFailureException passthrough or converts any other exception into a descriptive SeedFailureException — clean, correct fix. |
| frontend/src/widgets/copyable-cell/index.js | New CopyableCell widget using Ant Design Tooltip with clipboard copy on icon click and double-click; handles empty/null values, truncates tooltip at 500 chars, and cleans up timeout on unmount. |
| frontend/src/widgets/copyable-cell/copyable-cell.css | New CSS for copyable cell — correct overflow handling and tooltip layout styles. |
| frontend/src/ide/editor/no-code-model/no-code-model.jsx | Replaces raw <span> cell renderer with CopyableCell, extracts formattedValue/alignClass variables, fixes formCol call to include the previously-missing isWindowColumn arg, and adds setIsLoading(false) in the catch block. |
| frontend/src/base/components/environment/NewEnv.jsx | Removes customData state, EnvCustomDataSection, fetchProjectByConnection, getProjectDependency, and related handlers — clean dead-code removal with no functional regressions. |
| frontend/src/service/notification-service.js | Fixes empty notification title for markdown error messages by changing "" to "Failed" — small but correct bug fix. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[DuckDbSeed.execute called] --> B{db_connection is None?}
B -- Yes --> C[raise SeedFailureException\n'connection not available']
B -- No --> D[insert_csv_records]
D --> E{Exception raised?}
E -- No --> F[Success]
E -- SeedFailureException --> G[re-raise as-is]
E -- Other Exception --> H[wrap in SeedFailureException\n with table name + err message]
G --> I[Caller shows error notification]
H --> I
Reviews (2): Last reviewed commit: "addressing greptile cmt" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CopyableCellwidgetNoneTypeAttributeErrorWhy
pivot.csv) raised'NoneType' object has no attribute 'insert_csv_records'with no meaningfulfeedback to the user
How
frontend/src/widgets/copyable-cell/— a reusable component that shows a copy icon on hover and copies cell content to clipboard. Integrated into theno-code model table column renderer replacing raw
<span>elementsDuckDbSeed.execute()with a null guard ondb_connectionand a try/except that raisesSeedFailureExceptionwith the table name in the errormessage
EnvCustomDataSectionrendering, allcustomDatastate/handlers,fetchProjectByConnection, and related imports fromNewEnv.jsxCan this PR break any existing features. If yes, please list possible items. If no, please explain why.
SeedFailureExceptioninstead of rawAttributeErrorcustom_datain API payloads and stores it (no migration needed), so no backwardcompatibility issue
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
pivot.csv), run seed — should show a descriptive error notificationScreenshots
Checklist
I have read and understood the Contribution Guidelines.