Binary format - #3
Draft
DenisBiryukov91 wants to merge 25 commits into
Draft
DenisBiryukov91 wants to merge 25 commits into
DenisBiryukov91 wants to merge 25 commits into
Conversation
DenisBiryukov91
marked this pull request as draft
May 28, 2025 09:47
There was a problem hiding this comment.
Pull Request Overview
This PR, titled "Binary format", introduces multiple changes to improve serialization and encoding functionality as well as updates to various examples and plugin modules.
- Updated serialization and deserialization logic in the core library.
- Refactored encoding API and updated example usage with new language features.
- Adjusted plugin remote API, including dependency revisions and removal of unused files.
Reviewed Changes
Copilot reviewed 58 out of 58 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| zenoh-ts/src/ext/serialization.ts | Updates to buffer management and serialization methods; potential issue in finish() method. |
| zenoh-ts/src/enums.ts | Enum definitions updated for priority, reliability and others. |
| zenoh-ts/src/encoding.ts | Refactored Encoding class implementation with new enum based design. |
| zenoh-ts/examples/deno/* | Examples updated to use new language idioms and name changes. |
| zenoh-plugin-remote-api/src/lib.rs | Plugin remote API refactor; added dependency updates and changes to AdminSpaceClient. |
| Other plugin files | Removed obsolete serialization/deserialization modules. |
Comments suppressed due to low confidence (1)
zenoh-plugin-remote-api/src/lib.rs:278
- The register_subscriber() method incorrectly inserts the key expression into the publishers map instead of the subscribers map. Update the method to use self.subscribers.insert(...) accordingly.
self.publishers.insert(id, key_expr.toString());
| this.data = new Array(); | ||
| this.len = 0; | ||
| this.bufferLen = 0; | ||
| return new ZBytes(out); |
There was a problem hiding this comment.
The finish() method wraps an already constructed ZBytes instance in a new ZBytes call, which appears unintended. It is recommended to return 'out' directly.
Suggested change
| return new ZBytes(out); | |
| return out; |
allow to initialize deserializer from Uint8Array;
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.