Skip to content

fix: typehash mismatch nested .action msg - #334

Draft
sathak93 wants to merge 1 commit into
ZettaScaleLabs:mainfrom
sathak93:fix_action_typehash_mismatch
Draft

fix: typehash mismatch nested .action msg#334
sathak93 wants to merge 1 commit into
ZettaScaleLabs:mainfrom
sathak93:fix_action_typehash_mismatch

Conversation

@sathak93

Copy link
Copy Markdown

Description

Fix missing nested-dependency collection in action Goal/Result/Feedback type hashing

calculate_send_goal_hash, calculate_get_result_hash, and calculate_feedback_message_hash in hiroz-codegen's Resolver each insert the action's Goal/Result/Feedback TypeDescription into the deps map used to compute the corresponding RIHS01 type hash, but never call the existing collect_nested_deps helper to also pull in that type's own nested/referenced message dependencies. calculate_service_type_hash performs no recursive expansion of its own — it hashes exactly the flattened referenced_type_descriptions it's given — so any action whose Goal, Result, or Feedback message references a custom nested message type (e.g. a struct field typed as another message, not just primitives) gets an incomplete dependency set and therefore an incorrect RIHS01 hash.

Checklist

  • Ran ./scripts/check-local.sh successfully
  • Added/updated tests/documentation (if applicable)

External contributors: Please open as draft initially. See CONTRIBUTING.md.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sathak93 sathak93 changed the title fix typehash mismatch nested .action msg fix: typehash mismatch nested .action msg Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants