fix: typehash mismatch nested .action msg - #334
Draft
sathak93 wants to merge 1 commit into
Draft
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix missing nested-dependency collection in action Goal/Result/Feedback type hashing
calculate_send_goal_hash, calculate_get_result_hash, and calculate_feedback_message_hash in hiroz-codegen's Resolver each insert the action's Goal/Result/Feedback TypeDescription into the deps map used to compute the corresponding RIHS01 type hash, but never call the existing collect_nested_deps helper to also pull in that type's own nested/referenced message dependencies. calculate_service_type_hash performs no recursive expansion of its own — it hashes exactly the flattened referenced_type_descriptions it's given — so any action whose Goal, Result, or Feedback message references a custom nested message type (e.g. a struct field typed as another message, not just primitives) gets an incomplete dependency set and therefore an incorrect RIHS01 hash.
Checklist
./scripts/check-local.shsuccessfullyExternal contributors: Please open as draft initially. See CONTRIBUTING.md.