This repository was archived by the owner on Apr 19, 2026. It is now read-only.
Added Midnight portals#14
Open
Oylex wants to merge 4 commits into
Open
Conversation
Owner
|
Hi ! I’m sorry. I’m very busy at the moment, but I’ll take a look as soon as possible! Thank you very much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the new portals from Midnight.
I kept the new "current_season" category commented out until it starts
One thing I was not 100% sure, is that there is a new portal for Skyreach, so I added it next to the old one.
If learning one automatically makes you learn the other one, then we can remove one of them.
If they stay separate portals, we could clean this up by showing only one of them and priorizing the learned one.
I also added the translations based on Wowhead and the Blizzard's website, most locales keep the expansion names the same.
I also increased the height of the option frame to fit the new expansions (adding a scroll bar seemed a bit complicated to me, I'm not used to coding for WoW )
Let me know if there is something I should fix here, I already use this change in my WoW and it seems to work fine (along with the other PR #13)