feat: Add accounts filter to mpt_holders - #3180
Open
PeterChen13579 wants to merge 7 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the mpt_holders RPC handler to support an optional accounts filter that bypasses the holder-index scan and instead fetches MPToken objects directly by key for the requested accounts, while keeping the response shape consistent.
Changes:
- Add
accountsrequest parameter validation (non-empty array of base58 accounts, max 100). - Implement an
accountsfast-path that fetches MPToken ledger objects viakeylet::mptoken(...)keys and omits non-holders. - Add comprehensive unit tests covering valid/invalid
accountsusage, marker rejection, and confidential-transfer fields.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/unit/rpc/handlers/MPTHoldersTests.cpp | Adds unit tests for the new accounts filter mode and validation errors; renames test JSON constants. |
| src/rpc/handlers/MPTHolders.hpp | Adds accounts to the handler input and RPC spec with custom validation; introduces kMaxAccounts. |
| src/rpc/handlers/MPTHolders.cpp | Adds accounts fast-path using fetchLedgerObjects and factors MPToken JSON serialization into a helper. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
godexsoft
previously approved these changes
Aug 25, 2026
godexsoft
left a comment
godexsoft
left a comment
Collaborator
There was a problem hiding this comment.
Small nits that can be ignored 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing work from #3154 as we do not have permission to push to their personal fork