test(chain): add unit tests for ToHTTPURL and DropsToXRP#30
Open
Sanka-D wants to merge 1 commit into
Open
Conversation
pkg/chain had no tests. Cover the two pure helpers: - ToHTTPURL: ws→http / wss→https, and the local-dev remap of WS port 6006 to JSON-RPC port 5005 (incl. edge cases: non-6006 ports and non-localhost hosts are left untouched, wss does not remap ports). Also assert NewClient wires the remapped URL. - DropsToXRP: drops→XRP formatting, including sub-XRP amounts and unparseable input. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/chainwas the remaining pure-logic package with no unit tests. This addspkg/chain/client_test.gocovering its two pure helpers.Tests
ToHTTPURL— the WS→HTTP(S) conversion used to talk JSON-RPC:ws://→http://,wss://→https://6006→ JSON-RPC port50056006ports and non-localhosthosts are left untouched;wssdoes not remap portsNewClient(...)wires the remapped URL onto the clientDropsToXRP— drops→XRP formatting, incl. sub-XRP amounts and unparseable input (→ zero)Notes
Complements the existing suite (
pkg/abi,pkg/config,pkg/primitives,pkg/wallet).go test ./...andgo vet ./...pass.🤖 Generated with Claude Code