fix(jdk-codemodel): resolve Symbol.PatternBinding for record-deconstruction pattern components#119
Merged
Merged
Conversation
…uction pattern components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record-deconstruction pattern components (e.g.
x,yincase Point(int x, int y) ->) were converted toInstanceOf.Pattern.Binding/InstanceOf.Pattern.Recordnodes, but the underlying binding variables were never registered withJdkExpressionConverter, unlike simple type patterns handled inSymbol.PatternBindingresolution. As a result, identifier usages of those component variables inside the case/if body would resolve to aSymbol.PatternBindingwith an emptydeclaration(), losing the link back to the pattern test that introduced them.This adds a
registerNestedPatternBindingshelper onJdkExpressionConverterthat recursively walks aPatternTreeand registers every nestedBindingPatternTreeagainst the enclosingInstanceOf, mirroring the registration already done for top-levelBindingPatternTreebindings. It is invoked from both places that build a deconstructionInstanceOf:JdkExpressionConverter.visitInstanceOfforinstanceofexpressions, andJdkStatementConverter.convertPatternLabelfor switch-case deconstruction labels.Verified by adding
shouldResolveInstanceOfDeconstructionPatternComponentBindingandshouldResolveSwitchDeconstructionPatternComponentBindingtoSymbolResolutionTests, asserting that identifiers for deconstructed components resolve toSymbol.PatternBindinginstances whosedeclaration()points back to the correctInstanceOf.