chore(codemodel-foundation): add getEmptyModuleTypeName convenience to NameProvider and CodeModel#117
Merged
Merged
Conversation
…o NameProvider and CodeModel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callers that resolve a
TypeNamefor the unnamed module were repeating the same two-step chain everywhere:nameProvider.getTypeName(Optional.empty(), fullyQualifiedName)or, further out,codeModel.getNameProvider().getTypeName(Optional.empty(), fullyQualifiedName). Both are now collapsed into a singlegetEmptyModuleTypeName(fullyQualifiedName)call.NameProvider.getEmptyModuleTypeNameis a default method that delegates to the existinggetTypeName(Optional.empty(), fullyQualifiedName)overload.CodeModel.getEmptyModuleTypeNameis a matching default method that delegates throughgetNameProvider(), mirroring the shape of the other convenience overloads already onCodeModelsuch asgetTypeDescriptorandcreateTypeDescriptor.All call sites across
codemodel-foundation,jdk-codemodel, andjdk-annotation-processorwere updated to use the new helper, includingJDKModuleDescriptorand the bulk of the test suites that construct types by fully-qualified name.