feat(jdk-codemodel): promote EnumConstantDescriptor to Traitable and stamp its declaration-site source location#109
Merged
Merged
Conversation
…stamp its declaration-site source location
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnumConstantDescriptorused to only implementTrait, so unlikeFieldDescriptor,FormalParameterDescriptor, andLambdaParameter, it had nowhere to attach aSourceLocation.FilePositionfor the enum constant's declaration. This promotes it to also extendAbstractTraitableand implementTraitable, adding the@Marshal/@Unmarshalpair andMarshalling.registercall needed for that, matching the structural shape of the earlierLambdaParameterpromotion.JdkInitializer.processMembersnow callsaddSourceLocationon eachEnumConstantDescriptorit creates, the same way it already does for fields, methods, and parameters.Also renamed
LocationTraitTeststoSourceLocationTests(and its test method names from...ShouldCarryLocationTraitto...ShouldCarrySourceLocation) since there is noLocationTraittype in the codebase -- the actual trait isSourceLocation, and the old name's javadoc reference to{@link LocationTrait}didn't resolve to anything.