feat(jdk-codemodel): promote LambdaParameter to Traitable and stamp its declaration-site source location#105
Merged
Merged
Conversation
…ts declaration-site source location
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LambdaParameterwas a plainCompositerecord with nowhere to attach aSourceLocation, unlikeFieldDescriptorandFormalParameterDescriptor. It's promoted to aTraitableclass with full marshalling support, closing the last gap in the declaration-site position coverage added across the prior three PRs.Lambda's marshalling is simplified to round-trip parameters as a single stream instead of two zipped type/name streams.JdkExpressionConverternow stamps each lambda parameter with its source location the same way method/constructor parameters and locals already are.