fix: Fix modifier types#3896
Draft
alanbsmith wants to merge 1 commit into
Draft
Conversation
alanbsmith
added
14.x
ai author
Workday/canvas-kit
 |
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
ISSUE-3895
|
| Run status |
|
| Run duration | 02m 36s |
| Commit |
|
| Committer | Alan B Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
1
|
 |
86
|
 |
0
|
 |
863
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
19.46%
|
|
|---|---|
|
|
1550
|
|
|
372
|
Accessibility
99.33%
|
|
|---|---|
|
|
6 critical
5 serious
0 moderate
2 minor
|
|
|
78
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TypeScript typing for createStencil so modifier types merge correctly when a stencil extends another stencil, addressing the modifier inference issue reported in #3895.
Changes:
- Introduce
RemoveIndexSignature/MergeModifiersto prevent index-signature-driven inference issues when combining modifier configs. - Apply
MergeModifiersin the relevantStencil*conditional types so extended + local modifiers compose cleanly. - Update unit tests to no longer require
modifiers: {}on a base stencil for boolean modifier scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/styling/lib/cs.ts | Fixes extended-stencil modifier type composition by merging modifier types while stripping index signatures that break inference. |
| modules/styling/spec/cs.spec.tsx | Removes now-unnecessary modifiers: {} setup in tests, validating improved type inference/usage ergonomics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #3895
Update type of
createStencilto allow modifier merging when extending stencils.Release Category
Components
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)