Fix get_col_charset and get_col_length when using pre_get_table_charset filter #10646
Conversation
|
Hi @matt-h! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
matt-h
force-pushed
the
get_col_charset_fix
branch
from
200e80b to
e88ec3c
Compare
It previously used a cached values array throughout the code which relied on get_table_charset being run to prime the cache. If the pre_get_table_charset was set then the cache would never be primed and cache checks would throw errors. Fixes #38921 and #59836
matt-h
force-pushed
the
get_col_charset_fix
branch
from
e88ec3c to
f45fe86
Compare
|
|
||
| $charsets = array(); | ||
| $columns = array(); | ||
| $columns = $this->get_cols_meta( $table ); |
There was a problem hiding this comment.
Use $tablekey as it convert $table value to strtolower and remove strtolower from get_cols_meta.
There was a problem hiding this comment.
I don't agree with this. Using $tablekey would be fine here, but strtolower shouldn't be removed from get_cols_meta as get_cols_meta is used in more than 1 place and could be used elsewhere in the future. Removing it from there would require a tablekey being passed in all the time instead of just table so you'd always need to make sure strtolower is called first which would make the function less resilient/consistant.
3 participants
Change how column meta is pulled so it uses a
get_cols_metaandget_col_metafunction.This is to consolidate the database request so it has a single source of truth.
It previously used a cached values array throughout the code which relied on
get_table_charsetbeing run to prime the cache. The priming of the cache was a side effect of that function.If the
pre_get_table_charsetwas set then the cache would never be primed and cache checks would throw errors.We now always get the values from the functions which can be cached but not rely on the cache being primed.
Trac ticket: https://core.trac.wordpress.org/ticket/38921
Trac ticket: https://core.trac.wordpress.org/ticket/59836
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.