Trac #64428: Remove default type attributes from SCRIPT and STYLE ele… #10645
Conversation
|
Hi @hardikRathi! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
hardikRathi
force-pushed
the
64428-remove-script-style-type
branch
from
8a1fda9 to
9cbb060
Compare
sirreal
left a comment
sirreal
left a comment
There was a problem hiding this comment.
Thank you for working on this 🙌
I've left some feedback.
src/wp-includes/script-loader.php
Outdated
|
|
||
| $concat = trim( $wp_scripts->concat, ', ' ); | ||
| $type_attr = current_theme_supports( 'html5', 'script' ) ? '' : " type='text/javascript'"; | ||
| $type_attr = ''; |
There was a problem hiding this comment.
It seems like this variable and its interpolation can be removed here.
src/wp-includes/script-loader.php
Outdated
|
|
||
| $concat = trim( $wp_styles->concat, ', ' ); | ||
| $type_attr = current_theme_supports( 'html5', 'style' ) ? '' : ' type="text/css"'; | ||
| $type_attr = ''; |
There was a problem hiding this comment.
Same, it seems like this variable and its interpolation can be removed here.
src/wp-includes/script-loader.php
Outdated
| if ( isset( $attributes['type'] ) && 'text/javascript' === $attributes['type'] ) { | ||
| unset( $attributes['type'] ); |
There was a problem hiding this comment.
This logic to remove the explicitly added type attribute is new, that did not exist before.
Will you explain your reasoning on that? To me, it doesn't seem like this function needs to remove attributes that have been explicitly added even if they may be redundant.
src/wp-includes/script-loader.php
Outdated
| ! isset( $attributes['type'] ) || | ||
| 'module' === $attributes['type'] || | ||
| str_contains( $attributes['type'], 'javascript' ) || | ||
| str_contains( $attributes['type'], 'ecmascript' ) || | ||
| str_contains( $attributes['type'], 'jscript' ) || | ||
| str_contains( $attributes['type'], 'livescript' ) |
There was a problem hiding this comment.
This is interesting and my first impression was that this work should be separate from the type attribute. However, this is certainly related to HTML5 and script tags, if the type attribute is redundant, then this likely is as well.
If we're going to change how this works, I think the most appropriate thing is to remove the CDATA wrappers entirely.
I think we can maintain the previous behavior by restoring the ! current_theme_supports( 'html5', 'script' ) && ( /*…*/ ) check to this conditional
|
A whole bunch of unit tests will need to be updated to account for the removal of the |
I think it's important that these tests show differences in this case. I'd like |
sirreal
left a comment
sirreal
left a comment
There was a problem hiding this comment.
The changes look good but many tests need updating.
|
I've done some more work on this ticket in #10658. |
3 participants
Trac ticket: https://core.trac.wordpress.org/ticket/64428