Improve transaction behavior compatibility, add PDO-like APIs #294
+342
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanJakes
force-pushed
the
improve-transactions
branch
from
5ecb8f0 to
aed66fe
Compare
JanJakes
force-pushed
the
improve-transactions
branch
from
dd87630 to
816e0b5
Compare
adamziel
reviewed
Dec 18, 2025
| * @var bool | ||
| */ | ||
| private $transaction_level = 0; | ||
| private $in_transaction = false; |
adamziel
reviewed
Dec 18, 2025
| * @see https://bugs.php.net/bug.php?id=81227 | ||
| * @see https://github.com/php/php-src/pull/14268 | ||
| */ | ||
| return $this->in_transaction; |
adamziel
reviewed
Dec 18, 2025
| * Execute the "BEGIN" or "START TRANSACTION" MySQL statement in SQLite. | ||
| */ | ||
| private function begin_user_transaction(): void { | ||
| // MySQL implicitly commits previous transaction when starting a new one. |
Collaborator
There was a problem hiding this comment.
TIL, really good digging
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting smaller chunks from #291 so we can review and merge them independently.
This PR includes the following changes:
ATTR_ERRMODEsetting.PDO::inTransaction()on PHP < 8.4, where it is not reliable (issue, PR).