Skip to content

Fix Header Vertical overlay colors to use Ipsum palette slugs - #151

Open
shail-mehta wants to merge 1 commit into
WordPress:trunkfrom
shail-mehta:fix/header-vertical-overlay-colors
Open

shail-mehta wants to merge 1 commit into
WordPress:trunkfrom
shail-mehta:fix/header-vertical-overlay-colors

Conversation

@shail-mehta

@shail-mehta shail-mehta commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Description

The Header Vertical pattern set the navigation overlay to base / contrast, which are not registered in Ipsum’s palette (theme-1- theme-6). The open menu fell back to a plain white panel with black text and ignored the active color variation.

This updates the overlay to theme-6 (background) and theme-1 (text), matching the theme’s other inverted overlays (e.g. navigation overlay) so the menu tracks every color variation.

Screenshots

Before After
before after

Testing Instructions

  1. Activate Ipsum; clear any customized Header template part if Header Vertical was already inserted (Site Editor → Header → Clear customizations), or re-insert the Header Vertical pattern and save.
  2. On the front end, open the menu from Header Vertical.
  3. Confirm the overlay uses theme colors (not a plain white sheet).
  4. Switch to at least one other color variation (e.g. After Hours and the default) and confirm the overlay still contrasts correctly (theme-6 background / theme-1 text).
  5. Confirm typography style variations are unaffected.

Use of AI Tools

  • Cursor, for the PR Description

@github-actions github-actions Bot added the [Area] Patterns Issues or PRs that touch the theme's block patterns. label Oct 9, 2026
@shail-mehta
shail-mehta marked this pull request as ready for review October 9, 2026 09:11
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <shailu25@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Patterns Issues or PRs that touch the theme's block patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant