Repository navigation
Use get_parent_theme_file_uri() for theme stylesheets - #150
Open
shail-mehta wants to merge 1 commit into
Open
shail-mehta wants to merge 1 commit into
shail-mehta wants to merge 1 commit into
Conversation
shail-mehta
marked this pull request as ready for review
October 9, 2026 06:59
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a small parent-theme improvement: load Ipsum’s stylesheets with
get_parent_theme_file_uri()so the parent CSS continues to load correctly when a child theme is active.Ipsum already works well on its own. Relative stylesheet paths and
get_stylesheet_directory_uri()resolve to the active theme, which is usually fine, but with a child theme they can point at the child instead of Ipsum. Usingget_parent_theme_file_uri()keeps parentstyle.cssandeditor-style.cssavailable in both cases, similar to Twenty Twenty-Five.Changes
functions.phpstyle.csswithget_parent_theme_file_uri( 'style.css' ).style.cssandassets/css/editor-style.csswithget_parent_theme_file_uri().No intentional visual change when Ipsum is used without a child theme.
Testing Instructions
npm run lint:phpif PHPCS is set up locally.Use of AI Tools