Skip to content

Breaking API present in v159, applied hotfix + Added Mp4 converter to image - #47

Open
voncention1 wants to merge 4 commits into
WilloIzCitron:v8from
voncention1:v9
Open

Breaking API present in v159, applied hotfix + Added Mp4 converter to image#47
voncention1 wants to merge 4 commits into
WilloIzCitron:v8from
voncention1:v9

Conversation

@voncention1

Copy link
Copy Markdown

Applied hotfix for Mindustry v159 and onward.
Deleted previous PR due to rushed fix. Proper branch now.

Some API present in v159 (specifically LoadingFragment) were changed, hence some exceptions were thrown when connecting to multiplayer servers.

Moved bytecode generation to Java 17 since newer Mindustry expect JRE 17 anyway.

@xhstoyea

Copy link
Copy Markdown
Contributor

Seriously, I really thought the author was not going to continue updating.

@xhstoyea

Copy link
Copy Markdown
Contributor

Screenshot_2026-07-19-14-47-16-301_com.github.android.jpg
The last submission was even in February.

@voncention1

Copy link
Copy Markdown
Author

Seriously, I really thought the author was not going to continue updating.

Personally, this mod is one of my favorite.
Seeing it break and hasn't seen it updated is what motivated me to fork this.
I will, however, continue maintaining a fork of this repository if the author prefers to discontinue the project.

@xhstoyea

Copy link
Copy Markdown
Contributor

Seriously, I really thought the author was not going to continue updating.

Personally, this mod is one of my favorite.
Seeing it break and hasn't seen it updated is what motivated me to fork this.
I will, however, continue maintaining a fork of this repository if the author prefers to discontinue the project.

I understand how you feel. Maybe you can go to Discord to find him?

@xhstoyea

Copy link
Copy Markdown
Contributor

Oh, no, he doesn't seem to allow others to add him casually.

@voncention1

Copy link
Copy Markdown
Author

Oh, no, he doesn't seem to allow others to add him casually.

That's unfortunate, and it is understandable.

@xhstoyea

Copy link
Copy Markdown
Contributor

yup

@voncention1 voncention1 changed the title Breaking API present in v159, applied hotfix Breaking API present in v159, applied hotfix + Added Mp4 converter to image Jul 31, 2026
@voncention1

Copy link
Copy Markdown
Author

Just came back from experimental.

I have found some... VRAM usage inefficiency when loading L2D. Fine for 40-90 image frames. Problematic for hundreds.

Hence, introduced buffer system to accommodate the new MP4Decoder (Video to Image Frames).

Future plan involve accepting mp4 directly without image frame conversions.

@voncention1

Copy link
Copy Markdown
Author

Since it's still in experimental phase, the game is expected to freeze a bit longer during decoding due to maximizing thread usage (which will cause a bit more battery drainage).

However, the system itself is pretty stable and have produced expected results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants