Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/CI.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
distribution: "temurin"

- name: Set up Gradle
uses: gradle/actions/setup-gradle@v5
uses: gradle/actions/setup-gradle@v6
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Proprietary caching component bundled in v6

gradle/actions@v6 moves its caching logic into gradle-actions-caching, a proprietary component governed by separate Terms of Use (gradle.com/legal/terms-of-use). Because neither workflow explicitly sets cache-disabled: true, caching is on by default — meaning the proprietary component will be loaded and its license terms apply.

If the team agrees to those terms, this is fine as-is. If not, caching can be opted out of per step:

Suggested change
uses: gradle/actions/setup-gradle@v6
uses: gradle/actions/setup-gradle@v6
with:
cache-disabled: true

The same consideration applies to Release.yaml line 33 and the dependency-submission step in CI.yaml (line 53). This is already noted in the PR description, so it's mainly worth an explicit team decision before merging.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/CI.yaml
Line: 27

Comment:
**Proprietary caching component bundled in v6**

`gradle/actions@v6` moves its caching logic into `gradle-actions-caching`, a proprietary component governed by separate Terms of Use (gradle.com/legal/terms-of-use). Because neither workflow explicitly sets `cache-disabled: true`, caching is on by default — meaning the proprietary component will be loaded and its license terms apply.

If the team agrees to those terms, this is fine as-is. If not, caching can be opted out of per step:

```suggestion
        uses: gradle/actions/setup-gradle@v6
        with:
          cache-disabled: true
```

The same consideration applies to `Release.yaml` line 33 and the `dependency-submission` step in `CI.yaml` (line 53). This is already noted in the PR description, so it's mainly worth an explicit team decision before merging.

How can I resolve this? If you propose a fix, please make it concise.


- name: Build and test
run: ./gradlew build
Expand All @@ -50,5 +50,5 @@ jobs:
run: ./gradlew publishAllPublicationsToCentralPortalSnapshots -x test

- name: Update dependency graph
uses: gradle/actions/dependency-submission@v5
uses: gradle/actions/dependency-submission@v6
continue-on-error: true
2 changes: 1 addition & 1 deletion .github/workflows/Release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
distribution: "temurin"

- name: Set up Gradle
uses: gradle/actions/setup-gradle@v5
uses: gradle/actions/setup-gradle@v6
with:
gradle-version: "9.2.1"

Expand Down