[Spec] Soundness spec typos - #237
Conversation
rossberg
left a comment
There was a problem hiding this comment.
Yes, looks good to me. Would you mind fixing these upstream as well?
|
|
||
| rule Extend_meminst: | ||
| {TYPE at `[n..m] PAGE, BYTES b*} `<= {TYPE at `[n'..m] PAGE, BYTES b'*} | ||
| {TYPE at `[n..m?] PAGE, BYTES b*} `<= {TYPE at `[n'..m?] PAGE, BYTES b'*} |
There was a problem hiding this comment.
These need to be ported to wasm-latest as well.
There was a problem hiding this comment.
I don't think I have access to open pull requests in upstream unfortunately.
|
I'd make you a collaborator, but I don't have my yubikey with me this week for admin access. But you should be able to create a PR normally from a fork. Even this repo should work for that, you just need to create a branch that is in sync with upstream, commit the fix there, and create a PR against upstream. |
|
Yes, in my exp it's easier to have a separate fork of the upstream |
|
@raoxiaojia, a PR for upstream doesn't need to be from this fork's main, you can create it from any branch. Just create one that is in sync with upstream's main: and then select spec/main as target for the PR in GitHub. |
Right, this is the revelation I'm missing all this time when I have 2 separate forks for spectec and the actual spec repo... |
Fair enough! Did not know you could do this. I'll do it soonish then! |
| rule Meminst_ok: | ||
| s |- {TYPE at `[n..m] PAGE, BYTES b*} : at `[n..m] PAGE | ||
| -- Memtype_ok: {} |- at `[n..m] PAGE : OK | ||
| s |- {TYPE at `[n..m?] PAGE, BYTES b*} : at `[n..m?] PAGE |
There was a problem hiding this comment.
Just to make it visible: added a fix for Meminst_ok and Tableinst_ok which also were only valid for defined max
Some typos in the soundness spec that must be resolved for mechanization backends. @rossberg does the store extension change make sense? Previously the store extension relations only allowed memories/tables with a defined max.