Skip to content

[Spec] Soundness spec typos - #237

Open
DCupello1 wants to merge 6 commits into
mainfrom
soundness-extension-typo
Open

[Spec] Soundness spec typos#237
DCupello1 wants to merge 6 commits into
mainfrom
soundness-extension-typo

Conversation

@DCupello1

Copy link
Copy Markdown

Some typos in the soundness spec that must be resolved for mechanization backends. @rossberg does the store extension change make sense? Previously the store extension relations only allowed memories/tables with a defined max.

@rossberg rossberg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good to me. Would you mind fixing these upstream as well?


rule Extend_meminst:
{TYPE at `[n..m] PAGE, BYTES b*} `<= {TYPE at `[n'..m] PAGE, BYTES b'*}
{TYPE at `[n..m?] PAGE, BYTES b*} `<= {TYPE at `[n'..m?] PAGE, BYTES b'*}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be ported to wasm-latest as well.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I have access to open pull requests in upstream unfortunately.

@rossberg

rossberg commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

I'd make you a collaborator, but I don't have my yubikey with me this week for admin access. But you should be able to create a PR normally from a fork. Even this repo should work for that, you just need to create a branch that is in sync with upstream, commit the fix there, and create a PR against upstream.

@raoxiaojia

Copy link
Copy Markdown

Yes, in my exp it's easier to have a separate fork of the upstream spec repo directly to open PR for spec fixes, as this fork's main usually diverges with the upstream main which sometimes causes weird conflicts when opening PRs at upstream.

@rossberg

rossberg commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

@raoxiaojia, a PR for upstream doesn't need to be from this fork's main, you can create it from any branch. Just create one that is in sync with upstream's main:

git checkout -b my-pr-branch
git pull upstream  # if you haven't already
git reset --hard upstream/main
... # do your changes
git commit -a
git push -u

and then select spec/main as target for the PR in GitHub.

@raoxiaojia

Copy link
Copy Markdown

git reset --hard upstream/main

Right, this is the revelation I'm missing all this time when I have 2 separate forks for spectec and the actual spec repo...

@DCupello1

Copy link
Copy Markdown
Author

@raoxiaojia, a PR for upstream doesn't need to be from this fork's main, you can create it from any branch. Just create one that is in sync with upstream's main:

git checkout -b my-pr-branch
git pull upstream  # if you haven't already
git reset --hard upstream/main
... # do your changes
git commit -a
git push -u

and then select spec/main as target for the PR in GitHub.

Fair enough! Did not know you could do this. I'll do it soonish then!

rule Meminst_ok:
s |- {TYPE at `[n..m] PAGE, BYTES b*} : at `[n..m] PAGE
-- Memtype_ok: {} |- at `[n..m] PAGE : OK
s |- {TYPE at `[n..m?] PAGE, BYTES b*} : at `[n..m?] PAGE

@DCupello1 DCupello1 Jun 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make it visible: added a fix for Meminst_ok and Tableinst_ok which also were only valid for defined max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants