Open
Conversation
ehnuje
commented
Jan 31, 2021
- Spawned from Iterator support? #43 - Iterator support?
- I've checked the previous iterator-like implementation, Add VisitAllEntries method to iterate all entries in cache. #3
- This implementation avoids iterating the whole cache from a single function call. Instead, it copies keys from a bucket, not whole keys from a cache. And then it uses the copied key to retrieve the value from the cache.
|
LTGM! From the looks of it, this is a highly desirable feature and this PR looks pretty solid! |
|
When the number of traversals I traverse is large enough, it will cause the array to go out of bounds and cause a panic. Can you help me check it out? |
hhhhax
reviewed
Jul 26, 2023
| chunkIdx := idx / chunkSize | ||
| chunk := b.chunks[chunkIdx] | ||
|
|
||
| kvLenBuf := chunk[idx : idx+4] |
There was a problem hiding this comment.
This may cause the array to go out of bounds and generate Panic
There was a problem hiding this comment.
Adding this line of code may solve the problem, can you help me take a look? idx = idx % chunkSize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.