Add Java recording engine tests - #381
Merged
Merged
Conversation
Recording shipped with the original Java client and VibiumDev#332 added the video track; all the coverage lived in the JS and Python suites. Test start and stop with the zip landing at the declared path, the stop-time path override, explicit video failing at start on an engine without support, best-effort video reporting videoUnavailable, and the Firefox video track carrying real dimensions and duration. Fixes VibiumDev#380
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #380
The Java client has shipped the recording API since the original client drop and gained the video track in #332, with no tests on any of it: the coverage went into the JS and Python suites. This adds the missing Java engine tests.
Five tests in RecordingTest, class-marked with the core capability:
Video has no capability manifest entry, so the video tests branch on VIBIUM_ENGINE with JUnit assumptions, mirroring how the JS chrome-video and firefox suites split the same coverage.
Verified: