Preserve Java command caller frames - #377
Merged
vincebln2 merged 3 commits intoAug 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #337.
Captures the Java caller stack when a protocol command is dispatched and attaches it to protocol-created exceptions before they return to the waiting caller.
The transport's own send frames are trimmed, so failures point at the Page or Element operation and the user's calling method instead of mapError and the BiDi receive thread. Exception types and messages are unchanged.
Tests cover retaining the user call site, removing transport frames, and preserving the original error message.
Validation: ./gradlew validateCapabilityMarkers test --tests com.vibium.internal.BiDiClientTest