Sort docs by reader intent - #373
Merged
Merged
Conversation
The tutorial extractors skip code fences of other languages without consuming the pending test marker. In a doc that mixes JavaScript and Python blocks, the last JavaScript marker stayed pending until the first python fence anywhere in the file, so the Python sync suite picked up a phantom test whose body was the doc's standalone server example. That block calls serve_forever, which hung the suite until CI's 600s kill. Any fenced block now consumes the pending marker: it binds to the code block immediately after it or not at all. Same fix in both runners. Collected tests now match the pre-merge docs exactly (downloads 2+2, a11y 10+13); the phantom onDownload entry is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #328.
The docs taxonomy already defines tutorials as learning, how-to guides as doing, reference as lookup, and explanation as understanding, but several files still lived in the wrong quadrant or duplicated one guide per language.
What changed
Verified: