fix(riscv64): fix REH builds - #2921
Merged
Merged
Conversation
Contributor
Author
|
The compile step is failing with |
Member
|
Merge with the |
Contributor
Author
Thanks! I have rebased it on top of master branch. Initially I used the insider branch. |
Member
|
The REH archives are available |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the REH build failures that first occurred in #2903.
It increases the glibc version requirement for riscv64 REH builds to 2.35, because ubuntu jammy's cross toolchain uses glibc 2.35 (while the new node.js binary used in this PR supports 2.33).
However, the desktop application builds should still support glibc 2.33, because it is still using
focal-riscv64whose cross toolchain uses glibc 2.31 (while the electron riscv64 binary supports 2.33)The first commit switches to the jammy image. The second one replaces the node.js binary from unofficial-builds with my cross-compiled binary.