fix: preserve transparent RGB in quality 100 WebP - #281
Open
yeagoo wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libwebp can discard RGB channels beneath fully transparent pixels even when lossless coding is selected. For quality 100, set
webp:exact=trueso the decoded RGBA buffer is preserved, including invisible channel values. Leave the lossy encoder default unchanged.This can make transparent images larger without changing their displayed appearance. It is therefore a lossless-output policy choice, isolated for maintainer review.
Scope: inputs routed through
magickConvert, such as PNG → WebP. The existing GIF/WebP → GIF/WebP collection branch bypasses this helper (even for a single-frame WebP) and is not changed or covered by this fix.Validation
PNG fixtures contain hidden red RGB at alpha 0 as well as partial and opaque alpha. Both metadata settings must preserve every decoded channel at quality 100; quality 80 must leave the
webp:exactdefault untouched.bun run test: 8 passed, including five shared behavior tests.bun run build: passed with a local.envbased on.env.example.bun run check: the same 7 pre-existing missing Node type errors as upstream; no additional errors. Full-repository lint has existing failures outside this change; changed files pass.Patch structure
This branch is based on upstream
cc7b5a54d5e9c797b377db47b9bdfbb561707783and includes shared test harness commitc69e961, which moves the existingmagickConvertfunction unchanged into a utility imported by the worker. Tests invoke that exact production function with the installed WASM. No new package dependency is introduced.Each repair branch can be reviewed independently. After the shared harness lands, the remaining branches will need rebasing onto upstream main to resolve overlapping edits in
magick-convert.ts.Shares the behavior-preserving test harness with #275.