Skip to content

fix: enable lossless AVIF encoding at quality 100 - #277

Closed
yeagoo wants to merge 3 commits into
VERT-sh:mainfrom
yeagoo:fix/avif-lossless
Closed

fix: enable lossless AVIF encoding at quality 100#277
yeagoo wants to merge 3 commits into
VERT-sh:mainfrom
yeagoo:fix/avif-lossless

Conversation

@yeagoo

@yeagoo yeagoo commented Sep 7, 2026

Copy link
Copy Markdown

PNG/WebP to AVIF at quality 100 fails with the installed @imagemagick/magick-wasm@0.0.43:

Only --enable_chroma_deltaq=0 can be used with --lossless=1.

Configure 4:4:4 sampling and a full-range identity RGB/GBR matrix for lossless AVIF. This selects a compatible libheif/AOM path and avoids a lossy RGB-to-YUV transform. Preserve source CICP primaries/transfer or defer to an embedded ICC profile. The requested quality stays 100; lossy quality settings keep their existing chroma/CICP defaults.

Also cap AVIF input depth at the engine's actual quantum precision. A Q8 decode of a 16-bit-tagged PNG should not be expanded into a 12-bit AVIF with no additional precision.

References: ImageMagick defines, ImageMagick HEIC writer, libheif AOM encoder. The executable regression evidence uses the installed 0.0.43 WASM; the libheif link is a moving source reference.

Validation

Tests cover odd-sized PNG/WebP RGB and RGBA inputs, exact decoded pixels at quality 100, quality 80 defaults, CICP values, ICC retention/removal, and output depth at quality 60/100. Lossless refers to decoded Q8 pixels. This is an AVIF encoding fix; it does not claim to resolve HEIC/AVIF decoding errors. It does not change the default quality or promise AVIF will always be smaller than WebP.

  • bun run test: 15 passed, including five shared behavior tests.
  • The defect-focused tests fail against the unchanged upstream conversion function (9 failing tests before this fix).
  • bun run build: passed with a local .env based on .env.example.
  • ESLint and Prettier: changed files pass.
  • bun run check: the same 7 pre-existing missing Node type errors as upstream; no additional errors. Full-repository lint has existing failures outside this change; changed files pass.

Patch structure

This branch is based on upstream cc7b5a54d5e9c797b377db47b9bdfbb561707783 and includes shared test harness commit c69e961, which moves the existing magickConvert function unchanged into a utility imported by the worker. Tests invoke that exact production function with the installed WASM. No new package dependency is introduced.

Each repair branch can be reviewed independently. After the shared harness lands, the remaining branches will need rebasing onto upstream main to resolve overlapping edits in magick-convert.ts.

Shares the behavior-preserving test harness with #275.

@JovannMC

Copy link
Copy Markdown
Member

note: this is a boilerplate response for numerous open PRs

hiya!

firstly sorry for the late response to your PR (if it has been open for a while). we are closing this, along with other people's PRs, as we are preparing for the very overdue update drop. once merged, it will most likely break most existing PRs and will need to be redone. track the PR #282, and once merged you may wish to open another PR with the new base.

do also note this repository's and our main contributing guidelines which was made recently here, when submitting your new PR: repo & main

@JovannMC JovannMC closed this Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants