fix select - ./IRF.selectRunsForGammaHadronSeparationTraining.sh broken#152
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes run selection failures in IRF.selectRunsForGammaHadronSeparationTraining.sh by making zenith-bin parsing more robust (especially for JSON configs) and by improving how printRunParameter is invoked when EVNDISPSYS is a command-prefix (e.g., container wrapper).
Changes:
- Simplify and correct zenith-bin edge extraction from JSON (preserving order, de-duplicating edges) and normalize parsing into an array.
- Add input validation for zenith bin edges (must be numeric; must have at least two edges) to prevent downstream
bcerrors. - Fix
find -nameglob character classes for V4/V5 file selection and wrapprintRunParameterinvocation to support prefixedEVNDISPSYS.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bc issue in ./IRF.selectRunsForGammaHadronSeparationTraining.sh