v492 dev20#151
Merged
Merged
Conversation
GernotMaier
commented
Jun 5, 2026
Member
- dynamic memory adjustment for anasum combine
- improved log file checking
…g-to-docs Add changelog entry for PR #151 (v492-dev20)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the analysis/IRF shell script stack to better support apptainer-prefixed EVNDISPSYS execution, improves detection/handling of incomplete anasum logs, and adds dynamic HTCondor memory requests when combining large anasum runlists.
Changes:
- Add anasum-specific log validation in preprocessing and increase HTCondor memory for large combine runlists.
- Update many helper scripts to allow
EVNDISPSYSto be a word-splittable command prefix (apptainer exec) instead of a plain path. - Update environment/paths and CI action versions.
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/set_environment.sh | Updates ROOTSYS path/version for al9 environment setup. |
| scripts/preprocessing/prepro_check_and_clean_files.sh | Adds anasum log “last-line” validation and moves bad products to error. |
| scripts/IRF.trainTMVAforAngularReconstruction.sh | Normalizes output directory path (removes trailing slash). |
| scripts/IRF.production.sh | Improves bin selection/parsing for CARE sims; trims cutlist output; adjusts loop expansions for string lists. |
| scripts/helper_scripts/SPANALYSIS.make_DST_sub.sh | Supports apptainer-prefixed EVNDISPSYS by avoiding invalid source and enabling word-splitting execution. |
| scripts/helper_scripts/SPANALYSIS.lowgainped_sub.sh | Same apptainer/word-splitting execution adjustments as above. |
| scripts/helper_scripts/IRF.trainTMVAforGammaHadronSeparation_sub.sh | Same apptainer/word-splitting execution adjustments as above. |
| scripts/helper_scripts/IRF.trainTMVAforAngularReconstruction_sub.sh | Same apptainer/word-splitting execution adjustments as above. |
| scripts/helper_scripts/IRF.radial_acceptance_sub.sh | Same apptainer/word-splitting execution adjustments as above. |
| scripts/helper_scripts/IRF.optimizeTMVAforGammaHadronSeparation_sub.sh | Same apptainer/word-splitting execution adjustments as above. |
| scripts/helper_scripts/IRF.mscw_energy_MC_sub.sh | Same apptainer/word-splitting execution adjustments as above. |
| scripts/helper_scripts/IRF.lookup_table_parallel_sub.sh | Same apptainer/word-splitting execution adjustments as above. |
| scripts/helper_scripts/IRF.lookup_table_combine_sub.sh | Same apptainer/word-splitting execution adjustments as above. |
| scripts/helper_scripts/IRF.evndisp_MC_sub.sh | Same apptainer/word-splitting execution adjustments as above (including logFile calls). |
| scripts/helper_scripts/IRF.effective_area_parallel_sub.sh | Same apptainer/word-splitting execution adjustments; minor log cleanup ordering. |
| scripts/helper_scripts/IRF.effective_area_combine_sub.sh | Same apptainer/word-splitting execution adjustments as above. |
| scripts/helper_scripts/IRF.dispXGB_sub.sh | Same apptainer/word-splitting execution adjustments as above. |
| scripts/helper_scripts/IRF.compress_evndisp_MC_sub.sh | Same apptainer/word-splitting execution adjustments as above. |
| scripts/helper_scripts/ANALYSIS.mscw_energy_sub.sh | Same apptainer/word-splitting execution adjustments as above. |
| scripts/helper_scripts/ANALYSIS.evndisp_sub.sh | Same apptainer/word-splitting execution adjustments as above. |
| scripts/helper_scripts/ANALYSIS.dispXGB_sub.sh | Same apptainer/word-splitting execution adjustments as above. |
| scripts/helper_scripts/ANALYSIS.anasum_sub.sh | Same apptainer/word-splitting execution adjustments as above. |
| scripts/helper_scripts/ANALYSIS.anasum_combine_sub.sh | Same apptainer/word-splitting execution adjustments as above. |
| scripts/ANALYSIS.anasum_combine.sh | Adds runlist length detection and increases requested HTCondor memory for large combines. |
| .github/workflows/CI.yml | Updates GitHub Actions versions for checkout/setup-python. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.