Skip to content

v492 dev20#151

Merged
GernotMaier merged 15 commits into
mainfrom
v492-dev20
Jun 26, 2026
Merged

v492 dev20#151
GernotMaier merged 15 commits into
mainfrom
v492-dev20

Conversation

@GernotMaier

Copy link
Copy Markdown
Member
  • dynamic memory adjustment for anasum combine
  • improved log file checking

@GernotMaier GernotMaier self-assigned this Jun 5, 2026
@GernotMaier GernotMaier requested a review from Copilot June 26, 2026 12:13
@GernotMaier GernotMaier marked this pull request as ready for review June 26, 2026 12:13
…g-to-docs

Add changelog entry for PR #151 (v492-dev20)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the analysis/IRF shell script stack to better support apptainer-prefixed EVNDISPSYS execution, improves detection/handling of incomplete anasum logs, and adds dynamic HTCondor memory requests when combining large anasum runlists.

Changes:

  • Add anasum-specific log validation in preprocessing and increase HTCondor memory for large combine runlists.
  • Update many helper scripts to allow EVNDISPSYS to be a word-splittable command prefix (apptainer exec) instead of a plain path.
  • Update environment/paths and CI action versions.

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/set_environment.sh Updates ROOTSYS path/version for al9 environment setup.
scripts/preprocessing/prepro_check_and_clean_files.sh Adds anasum log “last-line” validation and moves bad products to error.
scripts/IRF.trainTMVAforAngularReconstruction.sh Normalizes output directory path (removes trailing slash).
scripts/IRF.production.sh Improves bin selection/parsing for CARE sims; trims cutlist output; adjusts loop expansions for string lists.
scripts/helper_scripts/SPANALYSIS.make_DST_sub.sh Supports apptainer-prefixed EVNDISPSYS by avoiding invalid source and enabling word-splitting execution.
scripts/helper_scripts/SPANALYSIS.lowgainped_sub.sh Same apptainer/word-splitting execution adjustments as above.
scripts/helper_scripts/IRF.trainTMVAforGammaHadronSeparation_sub.sh Same apptainer/word-splitting execution adjustments as above.
scripts/helper_scripts/IRF.trainTMVAforAngularReconstruction_sub.sh Same apptainer/word-splitting execution adjustments as above.
scripts/helper_scripts/IRF.radial_acceptance_sub.sh Same apptainer/word-splitting execution adjustments as above.
scripts/helper_scripts/IRF.optimizeTMVAforGammaHadronSeparation_sub.sh Same apptainer/word-splitting execution adjustments as above.
scripts/helper_scripts/IRF.mscw_energy_MC_sub.sh Same apptainer/word-splitting execution adjustments as above.
scripts/helper_scripts/IRF.lookup_table_parallel_sub.sh Same apptainer/word-splitting execution adjustments as above.
scripts/helper_scripts/IRF.lookup_table_combine_sub.sh Same apptainer/word-splitting execution adjustments as above.
scripts/helper_scripts/IRF.evndisp_MC_sub.sh Same apptainer/word-splitting execution adjustments as above (including logFile calls).
scripts/helper_scripts/IRF.effective_area_parallel_sub.sh Same apptainer/word-splitting execution adjustments; minor log cleanup ordering.
scripts/helper_scripts/IRF.effective_area_combine_sub.sh Same apptainer/word-splitting execution adjustments as above.
scripts/helper_scripts/IRF.dispXGB_sub.sh Same apptainer/word-splitting execution adjustments as above.
scripts/helper_scripts/IRF.compress_evndisp_MC_sub.sh Same apptainer/word-splitting execution adjustments as above.
scripts/helper_scripts/ANALYSIS.mscw_energy_sub.sh Same apptainer/word-splitting execution adjustments as above.
scripts/helper_scripts/ANALYSIS.evndisp_sub.sh Same apptainer/word-splitting execution adjustments as above.
scripts/helper_scripts/ANALYSIS.dispXGB_sub.sh Same apptainer/word-splitting execution adjustments as above.
scripts/helper_scripts/ANALYSIS.anasum_sub.sh Same apptainer/word-splitting execution adjustments as above.
scripts/helper_scripts/ANALYSIS.anasum_combine_sub.sh Same apptainer/word-splitting execution adjustments as above.
scripts/ANALYSIS.anasum_combine.sh Adds runlist length detection and increases requested HTCondor memory for large combines.
.github/workflows/CI.yml Updates GitHub Actions versions for checkout/setup-python.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/preprocessing/prepro_check_and_clean_files.sh
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@GernotMaier GernotMaier merged commit 165cf52 into main Jun 26, 2026
1 check passed
@GernotMaier GernotMaier deleted the v492-dev20 branch June 26, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants