v492-dev18#358
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates aimed at keeping EventDisplay_v4 building against newer ROOT releases (>= 6.38) and extending CI coverage to include a ROOT 6.38 container.
Changes:
- Updated ROOT
TF1construction inVPlotAnasumHistogramsto match newer ROOT APIs. - Extended the C++17 CI build matrix to include ROOT 6.38 and added an artifact/cache “prepare” job for external tarballs.
- Minor formatting/whitespace cleanups plus a small runtime log addition in
CData.
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/VStereoAnalysis.cpp |
Minor formatting adjustment in CData construction call site. |
src/VPlotAnasumHistograms.cpp |
Adjusted TF1 constructor usage for compatibility with newer ROOT. |
src/printRunParameter.cpp |
Whitespace/style tweak in a conditional print. |
src/makeEffectiveArea.cpp |
Minor indentation/formatting tweak in a boolean expression. |
src/CData.cpp |
Added an informational cout on successful XGB file open. |
docs/changes/358.maintenance.md |
Added changelog entry for ROOT>=6.38 compilation/CI adjustment. |
.github/workflows/ci-buildmatrix-cpp17.yml |
Added a prepare job + ROOT 6.38 image in matrix; changed VBF/SOFA acquisition flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition: