Fix OAuth connection overwriting existing connections - #1541
Merged
Conversation
…g a second Make connectionIdentifier idempotent with a fast path for names it already emits, and normalize the requested name in oauth.start so the free-name guard compares the exact string the mint stores. A second connect for the same integration now resolves to a suffixed name (e.g. localGmail2) instead of re-minting the first account's row. Fixes UsefulSoftwareCo#1540
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix OAuth connect overwriting an existing connection instead of adding a second
Make connectionIdentifier idempotent with a fast path for names it already emits, and normalize the requested name in oauth.start so the free-name guard compares the exact string the mint stores. A second connect for the same integration now resolves to a suffixed name (e.g. localGmail2) instead of re-minting the first account's row.
changes:
connection-name-identifier.ts: makeconnectionIdentifieridempotent. Fast-path inputs that are already in the tokenizer's output range, a lower letter followed by alphanumerics, and return them unchanged before tokenizingoauth-service.ts: normalize the requested name before the guard, leaves the mint free to mutate the name again on its second pass.Fixes #1540