Some required changes for CLSQL to work under Lispworks 7.#12
Open
tdrhq wants to merge 1 commit intoUnwashedMeme:masterfrom
Open
Some required changes for CLSQL to work under Lispworks 7.#12tdrhq wants to merge 1 commit intoUnwashedMeme:masterfrom
tdrhq wants to merge 1 commit intoUnwashedMeme:masterfrom
Conversation
I've been using this for a while now. LW7 requires an extra option to make sure slot values are not optimized when using MOP. The second fix is minor, I don't remember how exactly it affects CLSQL. But the feature check +:lispworks6 was used, whereas we really need something like lispworks6+. Since that feature doesn't exist we follow LW's guidelines and check for whether it's *not* lispworks4 or 5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using this for a while now. LW7 requires an extra option to
make sure slot values are not optimized when using MOP.
The second fix is minor, I don't remember how exactly it affects
CLSQL. But the feature check +:lispworks6 was used, whereas we really
need something like lispworks6+. Since that feature doesn't exist we
follow LW's guidelines and check for whether it's not lispworks4 or
5.