Reject fixed-layout page-count mismatches - #517
Draft
CyMule wants to merge 3 commits into
Draft
Conversation
State the entry count and PDF page count as separate clauses so the message reads correctly for single-page PDFs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValueErrorbefore page construction when the counts differWhy
The page construction path used
zip(), which silently stopped at the shorter input. Too few fixed layouts therefore produced a successful result with missing PDF pages.Compatibility note
This intentionally tightens validation: callers that previously supplied extra fixed layouts (which were ignored) will now receive an error. The draft status leaves room to confirm that contract before merging.
Validation
uv run --locked --no-sync pytest -q test_unstructured_inference/inference/test_layout.py— 54 passed