Repository navigation
gpui_parley: move to Parley 0.12 - #22
Merged
Merged
Conversation
Parley 0.12 (and fontique 0.12) for the Unity Hub, which patches Parley and needs gpui-ce on the same version. API changes: - InlineBox takes a baseline and a vertical alignment: `None` (the box's bottom edge) and `VerticalAlign::BASELINE` keep 0.11 placement. - AlignmentOptions::last_line_alignment: `None` keeps 0.11 behaviour. - Run::metrics is Run::font_metrics, which has no line height; the fallback uses ascent + descent + leading, the MetricsRelative(1.0) default. - LineMetrics lost ascent and descent; they come from the line's content bounds around its baseline. - Run::normalized_coords returns parlance coords; convert by bits. - Layout::inline_boxes is an ExactSizeIterator. Parley 0.12 keeps preserved whitespace that ends a paragraph inside the line box when it fits (CSS Text 4 conditional hanging), so `width_with_closing_whitespace` is gone and the block width is `Layout::width`. Its test now compares against the text without the space instead of `Layout::width`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A version change only: cargo update moves resvg and usvg and nothing else, and gpui-ce's tests and clippy pass unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the workspace to Parley 0.12 and fontique 0.12, so the Unity Hub can patch one Parley version (Unity-Technologies/unity-hub#18765).
API changes in
gpui_ce_parley:InlineBoxtakesbaseline: Noneandvertical_align: VerticalAlign::BASELINE, which keep 0.11 placement.AlignmentOptions::last_line_alignment: Nonekeeps 0.11 behaviour.Run::metricsis nowRun::font_metrics, which has no line height. The fallback uses ascent + descent + leading, theMetricsRelative(1.0)default.LineMetricslostascent/descent. They now come from the line's content bounds around its baseline.Run::normalized_coordsreturns parlance coords, converted by bits.Layout::inline_boxesis anExactSizeIterator.Parley 0.12 keeps preserved whitespace that ends a paragraph inside the line box when it fits (CSS Text 4 conditional hanging). That is what
width_with_closing_whitespace(#7) did by hand, so it is removed and the block width isLayout::width. Its test now compares against the text without the space.Also moves
gpui'sresvgandusvgto 0.49.0, a version change only, so the Hub's directusvg0.49 resolves one copy (Unity-Technologies/unity-hub#18768).Package versions are unchanged (
-unity.20261019); a new-unity.<date>release is still owed.Tests (macOS):
cargo test -p gpui_ce_parley -p gpui_ce_platform -p gpui_ce_elements,cargo test -p gpui-ce,cargo clippy -p gpui_ce_parley -p gpui-ce --all-targets -- -D warnings.🤖 Generated with Claude Code