Skip to content

test: complete Phase 2 media/presence/security/consistency/WS scenarios#54

Merged
ULookup merged 28 commits into
docs/test-architecture-designfrom
docs/test-architecture-phase2
Jul 16, 2026
Merged

test: complete Phase 2 media/presence/security/consistency/WS scenarios#54
ULookup merged 28 commits into
docs/test-architecture-designfrom
docs/test-architecture-phase2

Conversation

@ULookup

@ULookup ULookup commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Phase 2: media + presence + 安全 + 一致性 + WS + 并发 + L3 场景

继 Phase 1（PR #49）的测试基础设施与核心门禁后，本 PR 完成 Phase 2 的 Go 全栈黑盒测试扩展，并移除已被替代的 C++ gtest 目录。

任务状态

  • 原计划 Tasks 1–9、11–22：已实现并完成逐任务静态 review
  • Task 10（typing error paths）：因服务端采用 permissive 行为、与原计划错误路径假设冲突而记录为 dropped
  • 补充 Tasks 23–25：补齐删除 C++ 测试后 reviewer 发现的直接行为覆盖缺口
  • Final whole-branch review：无 Critical / Important，结论 Ready to merge

主要新增

  • media L2：CompleteUpload、multipart、dedup、quota、download、fileinfo、speech、object-key、magic-sniff quarantine
  • presence L2：multi-device、heartbeat、offline、subscribe、batch、unsubscribe
  • security L2：SQL injection literal search、XSS storage、path traversal object-key isolation
  • consistency / WS / concurrency：recall、timeline、friend/quota、通知链路、seq/dedup/reaction 并发
  • L3 scenarios：SC-05、SC-07～SC-12
  • trace coverage：Gateway 响应 X-Trace-Id 与 MQ→WS notify trace 透传
  • avatar coverage：AVATAR purpose 上传、profile 更新、公开 URL 合同
  • test framework：trace-aware HTTP client、purpose-aware media fixture、media DB record verifier、WS presence readiness
  • storage verification：MySQL + ES + MinIO 直接验证

C++ 测试清理

删除：

  • common/test/
  • media/test/
  • identity/test/

并移除根 CMakeLists.txt 对 common/test 的引用。等价外部行为已映射到现有 tests/pkg + tests/func 框架，不恢复独立测试体系。

Final review 修复

  • FN-MD-05 使用真实 MIME 大小上限输入并断言 5001
  • FN-CC-02 直接验证 message_id 与 seq_id 唯一
  • 收紧 SQL/path traversal/other-user download/reaction 断言
  • 用 presence condition polling 替代 WS 固定 500ms readiness sleep
  • 在 object-key 用例实际消费 MinIO verifier
  • 补齐 nil header 与忽略错误处理

验证说明

按本轮用户指示，本地环境未就位，因此未运行 go test、go vet、编译、CMake、Docker 或全栈测试。

已执行：

  • 所有变更文件 gofmt
  • 完整分支 git diff --check
  • 每任务独立静态 code review
  • Task 22 覆盖缺口复审
  • whole-branch review + fix re-review

运行时行为仍需在可用 Linux 全栈环境或 CI 中确认。

ULookup added 14 commits July 13, 2026 15:24
@ULookup
feat(test): add MinIO direct-query verifier for media consistency checks
8f1ac88
@ULookup
feat(test): add UploadFile and UploadLargeFile media fixtures
a59a76d
@ULookup
test(media): add FN-MD-01~03 CompleteUpload success/not-uploaded/idem…
cc07953 
…potent
@ULookup
test(media): add FN-MD-04~10 multipart upload init/apply/complete/abort
154acf2
@ULookup
test(media): add FN-MD-11~13 dedup/quota-exceeded/quota-remaining
24b9935
@ULookup
test(media): add FN-MD-14~16 download/other-user/fileinfo
7e1800a
@ULookup
test(media): add FN-MD-17~18 speech recognition invalid/empty audio
b95ff6c
@ULookup
test(presence): add FN-PR-01~03 multi-device/heartbeat/offline-on-dis…
b2fc362 
…connect
@ULookup
test(presence): add FN-PR-04/07/08 subscribe-notify/batch-mixed/unsub…
f3c6c52 
…scribe-idempotent
@ULookup
test(security): add FN-SEC-03~05 SQL injection/XSS/path traversal
42b0694
@ULookup
test(consistency): add FN-DC-04~07 recall/delete-timeline/friend-rela…
8d9ba78 
…tion/media-quota
@ULookup
test(ws): add FN-WS-03~07 friend-accept/conv-create/presence/reconnec…
f3fbbad 
…t/typing notifies
@ULookup
test(concurrency): add FN-CC-02~05 different-msgid/friend-race/media-…
8ab9f15 
…dedup/reaction

- FN-CC-02: 10 goroutines concurrent send with different client_msg_id,
  verify all 10 land in DB with unique message_ids
- FN-CC-03: Friend accept then immediate concurrent send (5 msgs),
  verify no message loss via DB count
- FN-CC-04: Concurrent ApplyUpload with same content_hash after initial
  upload, verify dedup returns identical file_id
- FN-CC-05: Two users (a+b) concurrently add same emoji reaction,
  verify get_reactions succeeds (idempotency)

All tests use real full-stack via fixture helpers (setupConv/sendMsg)
and DBVerifier.MessageCount for storage assertions. Compilation, go vet,
and gofmt all pass clean.
@ULookup
test(scenario): add SC-05 media upload full flow with dedup and multi…
d70313b 
…part
@ULookup ULookup changed the title docs(test): Phase 2 - media/presence/security/consistency L2 tests (12/22 tasks) docs(test): Phase 2 - media/presence/security/consistency/WS/CC/scenario L2-L3 tests (15/22 tasks) Jul 13, 2026
ULookup added 14 commits July 15, 2026 11:05
@ULookup
test(scenario): add SC-07 multi-device login kick
771f2fe
@ULookup
test(scenario): add SC-08 large group fan-out read diffusion (200 mem…
80e5ab9 
…bers)
@ULookup
test(scenario): add SC-09 unread count consistency cross-service
fa42bac
@ULookup
test(scenario): add SC-10 message recall visibility cross-device
4740b7d
@ULookup
test(scenario): add SC-11 token refresh flow after tampering
9071ca5
@ULookup
test(scenario): add SC-12 message search ES consistency
14b5d8e
@ULookup
test(scenario): poll SC-12 message search
571ba06
@ULookup
refactor(test): remove all C++ gtest directories (common/test, media/…
5108332 
…test, identity/test)

C++ behavior is fully covered by Go black-box tests:
- mime/jwt/content_hash/object_key/magic -> media_test.go + auth_middleware_test.go
- s3/media_dao integration -> SC-05 MediaUploadFullFlow + FN-DC-07 MediaQuota
- identity_client -> tests/pkg/client/http.go

Root CMakeLists.txt no longer add_subdirectory(common/test).
All C++ test build targets were already commented out (FIXME 3.0).
@ULookup
docs(test): design Go coverage for removed C++ tests
d2d2018
@ULookup
docs(test): plan framework-integrated C++ coverage replacement
65e388c
@ULookup
test(trace): add Gateway and MQ trace black-box coverage
ded4861
@ULookup
test(media): add avatar and object-key black-box coverage
9e958b9
@ULookup
test(media): cover asynchronous magic-sniff quarantine
a8d1b7a
@ULookup
test: address final review findings
a25d4a5
@ULookup ULookup changed the title docs(test): Phase 2 - media/presence/security/consistency/WS/CC/scenario L2-L3 tests (15/22 tasks) test: complete Phase 2 media/presence/security/consistency/WS scenarios Jul 15, 2026
@ULookup
ULookup marked this pull request as ready for review July 16, 2026 06:15
@ULookup
ULookup merged commit 2d63e3a into docs/test-architecture-design Jul 16, 2026
@ULookup ULookup mentioned this pull request Jul 16, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ULookup