Compute max-profit over all forms if "form" is None - #194
Merged
Merged
Conversation
Contributor
|
Good Catch! Maybe we should add a test to keep this from breaking again? |
Fine-tunes the fix so that the original form=None use case (flat table of attributes for a single form) continues to work, just in case anyone is using it.
smmaurer
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a bug: If the argument "form" is None, the max profit should be computed over all forms.
When calling the function with form=None, the original code failed at the line
df = df[df.max_profit_far > 0], sincedf.max_profit_fardoes not exist.