Skip to content

fix for lottery choice bug for empty alts table - #75

Open
mxndrwgrdnr wants to merge 1 commit into
devfrom
lotto_choice_empty_alts
Open

fix for lottery choice bug for empty alts table#75
mxndrwgrdnr wants to merge 1 commit into
devfrom
lotto_choice_empty_alts

Conversation

@mxndrwgrdnr

Copy link
Copy Markdown
Contributor

This PR fixes a bug initerative_lottery_choices() which creates an empty merged choice table object if/when all rows of alts table are filled and dropped before max capacity is exceeded.

@mxndrwgrdnr
mxndrwgrdnr requested a review from smmaurer April 19, 2022 22:41
@github-actions

Copy link
Copy Markdown

Test coverage is 76%

@waddell

waddell commented Aug 15, 2026

Copy link
Copy Markdown
Member

Thank you, @mxndrwgrdnr. UDST has resumed active maintenance of ChoiceModels, and this focused bug fix is now tracked under #78.

The failure mode is plausible: after the alternatives table has been exhausted, the loop should terminate before attempting to construct another merged choice table. Before integration, the change needs a regression test that exhausts the alternatives and verifies both clean termination and the expected unallocated-chooser behavior. We will also run it against the modern compatibility baseline once that CI work is in place.

If you are available and would like to add the test after the baseline is ready, that would be welcome. Otherwise, UDST can adapt the fix with the original authorship and explicit credit preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants