Repository navigation
Conversation
Collaborator
|
One possible bug that I had in mind was about the state after the cancellation in the middle of a Claude helped to find such cases: REVIEW-parser-cancellation.md (1 high, 3 medium, 3 low findings). |
Member
Author
|
Some of the issues in there are already resolved by #147, which should be merged first. |
msujew
force-pushed
the
msujew/parser-cancellation
branch
2 times, most recently
from
October 22, 2026 09:52
09c25c1 to
ac108a8
Compare
^ Conflicts: ^ examples/statemachine/benchmark_test.go ^ parser/parser.go ^ workspace/document_parser.go ^ Conflicts: ^ examples/arithmetics/completion_parser_gen.go ^ examples/statemachine/completion_parser_gen.go ^ internal/generator/parser_generator.go ^ internal/grammar/completion_parser_gen.go ^ internal/languages/completion/completion_parser_gen.go ^ internal/languages/lookahead/completion_parser_gen.go ^ internal/languages/token_groups/completion_parser_gen.go ^ internal/languages/token_modes/completion_parser_gen.go ^ parser/completion_parser.go
msujew
force-pushed
the
msujew/parser-cancellation
branch
from
October 22, 2026 10:56
ac108a8 to
3db1c3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #139
This is a relatively simple change that allows us to fix an issue that plagued us in Langium since its inception: Cancellation of in-progress lexer/parser runs. This ensures that we can immediately react to changes in the editors, instead of having to wait for lexer/parser runs to finish before doing that. In total, this means that every step of the builder is now 100% instantly cancellable.