Investigate polyclip-ts with floats instead of bignumber #2990
+980
−1,033
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes to the tests required to pick up an alternate version of polyclip-ts that has been migrated from the bignumber usage to native javascript floats for perf.
It did seem to reintroduce some errors that were previously fixed, but I'm thinking these are down to the precision issues at the ~12th decimal place.
The test failures here are expected, as I merely built polyclip-ts locally and linked to it on my machine instead of going through the work to create a self-publishing npm package.
@turf/union benchmarks:
So there's a massive speed improvement, but the unable-to-complete-output-ring tests are failing (sort of as expected).