Skip to content

feat(semconv): add conventional pull request action - #1

Merged
yordis merged 6 commits into
mainfrom
yordis/feat-semconv-action
Sep 21, 2026
Merged

yordis merged 6 commits into
mainfrom
yordis/feat-semconv-action

Conversation

@yordis

@yordis yordis commented Sep 21, 2026 •

Copy link
Copy Markdown
Member
  • Fifteen repositories across both orgs enforce conventional commits today, in four separate implementations that already disagree on which types are allowed. Consolidating removes the drift and gives contributors one answer.
  • The grammar lives in a single sourced file so that every future check in this family (branch names, for example) cannot diverge from the one used here.
  • Owning the validation rather than wrapping a third-party action keeps title and commit checking on one parser, and drops a supply-chain dependency from the critical path of every pull request in both orgs.
  • pull_request_target is deliberate: under pull_request the workflow file comes from the head, so the check could be rewritten by the change it is checking. It stays safe only while this job never checks out or executes pull request content, which is stated in the action and in its README.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

Preview blast radius → · Advanced feature

Warning

Review limit reached

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: 4915ebaa-5f3c-4fe8-a491-76ac7fb53fcf

📥 Commits

Reviewing files that changed from the base of the PR and between e6b0c3e and 09a648c.

📒 Files selected for processing (3)
  • .config/mise/tasks/github/actions/ci/lint
  • .github/workflows/ci.yml
  • mise.toml

TrogonStack is on CodeRabbit Free, which includes PR summaries. Ask your admin to upgrade for code reviews.

  • Ask an admin to upgrade

Open in CodeRabbit

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: 1d05cbbe-c24f-40d5-9173-667a72d9482c

📥 Commits

Reviewing files that changed from the base of the PR and between fc80cb6 and e6b0c3e.

📒 Files selected for processing (6)
  • .github/workflows/ci.yml
  • .github/workflows/semconv.yml
  • actions/semconv/README.md
  • actions/semconv/pull-request/README.md
  • actions/semconv/pull-request/action.yml
  • mise.toml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The change adds lint CI for workflows and shell scripts, updates semantic validation to inspect pull request titles through pull_request, and replaces configurable shell validation with a pinned semantic pull request action.

Changes

Repository Validation

Layer / File(s) Summary
Pull request title validation
actions/semconv/pull-request/action.yml, actions/semconv/pull-request/README.md, actions/semconv/README.md
The action now validates only titles with fixed feat, fix, and chore types, lowercase-starting subjects, and ignored labels. The documentation describes the updated inputs and limitations.
Semantic validation workflow integration
.github/workflows/semconv.yml
The workflow now uses pull_request, read-only contents access, and the Validate PR Title job name.
Repository lint CI
mise.toml, .github/workflows/ci.yml
The repository now pins Actionlint and ShellCheck, exposes a lint task, and runs that task on pushes and pull requests. The previous test task was removed.

Estimated code review effort: 3 (Moderate) | ~25 minutes


A rabbit checks each title line
Pinned tools guide the linting light
Shell scripts hop through checks
Workflows rest with guarded rights
Validation follows the pull request
The burrow stays clear tonight

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/feat-semconv-action branch from 7bb95cd to fc80cb6 Compare September 21, 2026 17:09
Only the pull request title reaches the default branch on a squash merge, and a maintained upstream already validates it better than a local grammar can. What this repository adds is one pinned version and one type list for every consumer.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…ository

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis changed the title feat(semconv): add conventional pull request action Add conventional pull request action Sep 21, 2026
@yordis yordis changed the title Add conventional pull request action feat(semconv): add conventional pull request action Sep 21, 2026
A task file whose path mirrors the workflow that calls it makes the pairing obvious from either side.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis merged commit 93c1599 into main Sep 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant