Improved logic for whether to apply commands at link time#56
Merged
RoadrunnerWMC merged 1 commit intoTreeki:masterfrom Mar 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the logic for
KamekFile.Contains()more accurate by adding a check for the address type, and updates call sites to remove the now-redundant check.It also changes the logic for
RelocCommand.Apply()to use the updatedContainsmethod instead of only checking the address type. Since the rest of the function assumes that it's safe to write into the file as long as that initial check passed, which is only actually true if the fileContainsthe address in question, this logic is more accurate, even if it's not currently possible to actually generate relocations that violate that assumption. (It will become possible once #54 is merged.)