-
-
Notifications
You must be signed in to change notification settings - Fork 70
Pluginval as dependency #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
89740ac to
1b833be
Compare
dcbe3cf to
db9523e
Compare
|
Am I supposed to be reviewing or merging this? You might notice I switched to CPM for a few other dependancies on develop. Can this branch be pulled in line with that? |
|
@drowaudio I've been using this branch for a year as a dependency of my synth but never got the example plugins running in CI. I'll need to get that going and resolve recent conflicts before it's mergable. |
|
Ah ok. Poke me if/when you get to that. I might switch to juce via CPM at some point soon anyway... |
dc9e598 to
b596c78
Compare
Closes #137
This improves support for pluginval as a CMake sub-project in a JUCE project.
PLUGINVAL_FETCH_JUCEoption (no longer needed, superseded by not being top level)Caveats:
Technically, this PR would make maintenance more complicated — it's now BYOJ, Bring Your Own JUCE — which means pluginval will be compiled against more than one version of JUCE. We could add a caveat in the README that there's no guarantees on other JUCE versions than what pluginval depends on, specify that it's JUCE 8 only, etc...